shinchiro / mpv-winbuild-cmake

CMake-based MinGW-w64 Cross Toolchain
654 stars 115 forks source link

mpv not opening after updating to 20230924. #445

Closed sunnysoren closed 1 year ago

sunnysoren commented 1 year ago

After installing latest version mpv-x86_64-20230924-git-140d018.7z using updater.bat, mpv is not opening, nor the video files are opening. And after that for some reason opening the updater giving me a "Cannot index into a null array" error. So I downgraded mpv to mpv-x86_64-20230917-git-181eddc.7z and it is working fine. Is something wrong with my system or it is something else?

Andarwinux commented 1 year ago

What CPU, what Windows Version?

sunnysoren commented 1 year ago

What CPU, what Windows Version?

Pentium G645, Windows 10 22H2 Build 19045.2846

Andarwinux commented 1 year ago

https://github.com/zhongfly/mpv-winbuild/releases/download/2023-09-24-652a1dd/mpv-x86_64-20230924-git-652a1dd.7z

Is this working fine?

sunnysoren commented 1 year ago

https://github.com/zhongfly/mpv-winbuild/releases/download/2023-09-24-652a1dd/mpv-x86_64-20230924-git-652a1dd.7z

Is this working fine?

No, same problem. Is it because my cpu doesn't have a lot of features? image

zhongfly commented 1 year ago

https://github.com/zhongfly/mpv-winbuild/releases/download/2023-09-24-652a1dd/mpv-x86_64-20230924-git-652a1dd.7z

Is this working fine?

https://github.com/zhongfly/mpv-winbuild/releases/tag/2023-09-24-652a1dd is also a clang build. try this gcc build https://github.com/zhongfly/mpv-winbuild/suites/16491527835/artifacts/942229799

sunnysoren commented 1 year ago

https://github.com/zhongfly/mpv-winbuild/releases/tag/2023-09-24-652a1dd is also a clang build. try this gcc build https://github.com/zhongfly/mpv-winbuild/suites/16491527835/artifacts/942229799

This is working. What's wrong with that clang build?

Andarwinux commented 1 year ago

The compilers are different, maybe clang defines -march=x86-64 differently than gcc and then crashes due to missing ISA features. You can try clang i686 build.

sunnysoren commented 1 year ago

So what can I do to run that latest clang build? Do I have to use the 32-bit version?

Andarwinux commented 1 year ago

If this is a llvm problem then you are out of luck, if it is a mpv-winbuild-cmake problem, will try to fix this. If you're unlucky, you may have to keep using gcc build.

shinchiro commented 1 year ago

I would suspect this might be caused by excessive polly optimization or that fcf-protection thing

Andarwinux commented 1 year ago

https://www.intel.com/content/www/us/en/docs/cpp-compiler/developer-guide-reference/2021-8/fcf-protection-qcf-protection.html

Intel® CET protections are enforced on processors that support Intel® CET. They are ignored on processors that do not support Intel® CET, so they are safe to use in programs that might run on a variety of processors.

I think the problem is more likely Polly or cfguard.

ben-whitehouse commented 1 year ago

This is also happening to me to on the latest build after using the updater.bat an hour ago. mpv is not opening, and the updater now gives me "Cannot index into a null array." I'm running Windows 10 on a Macbook Pro with an Intel i7-3720QM CPU. I'll try the other builds you suggest above.

Andarwinux commented 1 year ago

It seems that the CPUs with this problem are Bridge families? Are there any Lake families or AMD that have this problem?

AlifianK commented 1 year ago

Kaby Lake here, mpv runs fine. Intel Core i5 7200U, Windows 11 22H2

zhongfly commented 1 year ago

It seems that the CPUs with this problem are Bridge families? Are there any Lake families or AMD that have this problem?

AMD R5-3600 and R7-6800H works fine.

sakuhanachan commented 1 year ago

Haswell (i5 4690) can run clang's x86_64 and x86_64-v3 build without problem too.

plissken1138 commented 1 year ago

The problem was there after update to 20230924 and persists even after update to 20230925 on AMD FX-6300. I'm using umpvw, to mimic the single instance, and see umpvw in process explorer after double clicking on a video file but mpv refuses to open. After reverting to 20230923 I needed to run mpv's installer and then umpvw's installer to make it work as it did before.

I'm always updating with updater.bat and it didn't give me problems before 20230924 update.

Andarwinux commented 1 year ago

You don't actually need to run the updater, just replace mpv.exe.

So any ancient CPU will crash. Need to wait for someone to build a mpv with CFI/OPT disabled. can anyone get backtrace?

Andarwinux commented 1 year ago

https://github.com/shinchiro/mpv-winbuild-cmake/actions/runs/6296189408 https://github.com/shinchiro/mpv-winbuild-cmake/actions/runs/6296190508 https://github.com/shinchiro/mpv-winbuild-cmake/actions/runs/6296191361 https://github.com/shinchiro/mpv-winbuild-cmake/actions/runs/6296192398

@ben-whitehouse @sunnysoren try these

sunnysoren commented 1 year ago

@sunnysoren try these

It is not working. Still using the 20230917 version in the meantime.

Andarwinux commented 1 year ago

@sunnysoren try these

It is not working. Still using the 20230917 version in the meantime.

Do all four of these not working?

eko5624 commented 1 year ago

On my sandybrige notebook, all four of these don't work either. But my clang build works fine. @sunnysoren Can you try my build? https://github.com/eko5624/mpv-winbuild/releases/download/2023-09-24/static-mpv-20230924.7z

My clang toolchain repo is here: https://github.com/eko5624/toolchain

sunnysoren commented 1 year ago

Do all four of these not working?

Yeah, Sorry I didn't clarify earlier

sunnysoren commented 1 year ago

@sunnysoren Can you try my build?

I tried. It is running, but with lags and minor unresponsiveness. I'm not sure if it is the UI or the build.

eko5624 commented 1 year ago

@sunnysoren Can you try my build?

I tried. It is running, but with lags and minor unresponsiveness. I'm not sure if it is the UI or the build.

Try to add profile=fast to the first line in mpv.conf. Or just remove portable_config directory, and retry.

PrinceOC912 commented 1 year ago

Do all four of these not working?

I have the same problem on A6-5400B and none of the builds open for me. The last build I was able to get to work is 20230923

sunnysoren commented 1 year ago

Try to add profile=fast to the first line in mpv.conf.

@eko5624 Yeah I added profile=fast in protable_config/mpv.conf, now it's working. Your build is fine.

shinchiro commented 1 year ago

https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531330046/artifacts/944454133 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531326567/artifacts/944454798 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531322557/artifacts/944492344 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531318651/artifacts/944562759

Try these build. Previous builds, I forgot to wipe older cache

eko5624 commented 1 year ago

https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531330046/artifacts/944454133 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531326567/artifacts/944454798 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531322557/artifacts/944492344 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531318651/artifacts/944562759

Try these build. Previous builds, I forgot to wipe older cache

All four of these working now on my sandybrige laptop.

PrinceOC912 commented 1 year ago

Working for me as well.

Andarwinux commented 1 year ago

Since all four working fine, it doesn't seem to be a CFI/OPT problem. Maybe some sort of build cache problem is causing the x86-64 and x86-64-v3 caches to get mixed up? only the device without AVX crashes.

shinchiro commented 1 year ago

No issue with caches. What I see, polly optimization doesnt work well with mguard+fcf-protection (for older cpu)

Can try with this build a while to see whether it will crash or not? This build is with polly optimization+mguard https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531318651/artifacts/944562759

eko5624 commented 1 year ago

No issue with caches. What I see, polly optimization doesnt work well with mguard+fcf-protection (for older cpu)

Can try with this build a while to see whether it will crash or not? This build is with polly optimization+mguard https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531318651/artifacts/944562759

This build also works fine.

Andarwinux commented 1 year ago

@eko5624's toolchain also has cfguard+fcf-protection+polly, but everything working fine.

https://github.com/eko5624/toolchain/commit/3189b15117ebc5c8657f7b6197e366ee6e30e581#diff-498c69cbb220ee89374e2b9a3d1b03bea90ac848056b668fdb934c1ff34f5d42R7

shinchiro commented 1 year ago

But slow & unresponsive?

@sunnysoren Can you try my build?

I tried. It is running, but with lags and minor unresponsiveness. I'm not sure if it is the UI or the build.

Andarwinux commented 1 year ago

I suspect it's because mpv recently changed the default profile, profile=fast solved the problem.

Try to add profile=fast to the first line in mpv.conf.

@eko5624 Yeah I added profile=fast in protable_config/mpv.conf, now it's working. Your build is fine.

plissken1138 commented 1 year ago

No issue with caches. What I see, polly optimization doesnt work well with mguard+fcf-protection (for older cpu)

Can try with this build a while to see whether it will crash or not? This build is with polly optimization+mguard https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531318651/artifacts/944562759

This is working fine in my setup even without profile=fast

eko5624 commented 1 year ago

Check https://mpv.io/manual/master/#gpu-renderer-options

The default scale has been changed from bilinear to lanczos , higher configuration requirements, not friendly to low-end computers.

shinchiro commented 1 year ago

Can anyone with older cpu reconfirm again today's release fix this issue?

ben-whitehouse commented 1 year ago

Can anyone with older cpu reconfirm again today's release fix this issue?

I downloaded the bootstrapper and did a fresh install (which used mpv-x86_64-20230926-git-90e0828.7z). It did not work, failing in the same way as originally described.

Can try with this build a while to see whether it will crash or not? This build is with polly optimization+mguard https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531318651/artifacts/944562759

This one does work fine for me.

https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531330046/artifacts/944454133 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531326567/artifacts/944454798 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531322557/artifacts/944492344 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531318651/artifacts/944562759 Try these build. Previous builds, I forgot to wipe older cache

These 4 also work fine. Again, I'm an Intel i7-3720QM (Ivy Bridge) CPU.

PrinceOC912 commented 1 year ago

Not working for me.

plissken1138 commented 1 year ago

20230926 is no go on AMD FX-6300 (Win10 Edu 22H2)

kenarsene commented 1 year ago

20230926 not working for me also.

https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531330046/artifacts/944454133 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531326567/artifacts/944454798 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531322557/artifacts/944492344 https://github.com/shinchiro/mpv-winbuild-cmake/suites/16531318651/artifacts/944562759

Try these build. Previous builds, I forgot to wipe older cache

those 4 works.

shinchiro commented 1 year ago

How about this one? https://github.com/shinchiro/mpv-winbuild-cmake/suites/16589118431/artifacts/947908698

plissken1138 commented 1 year ago

How about this one? https://github.com/shinchiro/mpv-winbuild-cmake/suites/16589118431/artifacts/947908698

no go. from what I see in process explorer, something named WerFault.exe opens briefly after mpv.exe and then both close.

AMD FX-6300 (Win10 Edu 22H2)

ben-whitehouse commented 1 year ago

How about this one? https://github.com/shinchiro/mpv-winbuild-cmake/suites/16589118431/artifacts/947908698

Doesn't work for me either.

kenarsene commented 1 year ago

How about this one? https://github.com/shinchiro/mpv-winbuild-cmake/suites/16589118431/artifacts/947908698

Not working.

Andarwinux commented 1 year ago

Can anyone experiencing this problem try local build in WSL?

PrinceOC912 commented 1 year ago

Can anyone experiencing this problem try local build in WSL?

Tried with 20230926, still doesn't work.

shinchiro commented 1 year ago

Try this one? (for older cpu) https://github.com/shinchiro/mpv-winbuild-cmake/suites/16664918190/artifacts/952299110