shinchiro / mpv-winbuild-cmake

CMake-based MinGW-w64 Cross Toolchain
659 stars 117 forks source link

ffmpeg: remove nonfree flag #587

Closed zhongfly closed 10 months ago

zhongfly commented 10 months ago

"--enable-nonfree" makes ffmpeg unredistributable.But currently there are no dependencies that require this option to be enabled.

Only the following libs in ffmpeg require "--enable-nonfree":decklink,libfdk_aac,libtls.

Andarwinux commented 10 months ago

Since there are no nonfree dependencies, it is actually still redistributable. Some downstream users will enable libfdkacc, nvcc, etc. remove nonfree option would add trouble for them.

zhongfly commented 10 months ago

Some downstream users will enable libfdkacc, nvcc, etc

They can enable this by themselves.

Since there are no nonfree dependencies, it is actually still redistributable.

Run ffmpeg.exe -L to show license:

This version of ffmpeg has nonfree parts compiled in.
Therefore it is not legally redistributable.

But this option does change the ffmpeg licence.

shinchiro commented 10 months ago

Oh well whatever it is