shinesolutions / aem-aws-stack-provisioner

Puppet provisioner for AEM AWS Stack Builder
Apache License 2.0
4 stars 13 forks source link

Optimise Puppet logging #40

Open michaeldiender-shinesolutions opened 7 years ago

michaeldiender-shinesolutions commented 7 years ago

suggest that we pass in the --logdest option to puppet-apply commands with default value of syslog with ability to configure it to a file. referring to the stack management jobs: export-backups, import-packages etc.

cliffano commented 6 years ago

This ticket is about ensuring that aem-tools actions write to a log destination. This will be done as part of stack-provisioner (aws-related actions) and aem_curator (aem-related actions).

Destination is unlikely to be syslog at this point of time since the rest of the logs are written to filesystem and sent to CloudWatch. A separate effort will be needed to migrate everything to syslog.

cliffano commented 6 years ago

Since the introduction of Stack Manager, we also have to ensure that Puppet logging to filesystem does not swallow the stdout, because we still want the stdout for stack manager logging purpose. Remember that user will use Stack Manager log (which is presented right away on their CI/CD tool) much more frequently instead of SSH-ing into the machine to check the logs, or using AWS console to check the CloudWatch logs.

If we can only pick one between writing to file vs stdout, keep stdout.