Closed Siebes closed 5 years ago
Apologies for the very delayed review on this. I'm happy to merge but I have a couple of comments:
/etc/clientlibs
is generally used for core AEM libraries. Instead it's preferable place everything in /apps
and expose them using allowProxy
grid.less
which provides the aem-GridColumn
classescom.shinesolutions.helloworld.models
instead of com.shinesolutions.models
Ive done some tweaking with Priya's PR and I should now have a 6.2,6.3,6.4 package.
I had to remove some references to components in we-retail because they arnt installed by default on 6.2
I also changed the pictures to all come from unsplash due to licence concerns
Had a bunch of problems with 6.2 and trying to use the foundation page so I had to override
body.html