search

shinesolutions / ruby_aem_aws

Ruby client for Shine Solutions Adobe Experience Manager (AEM) Platform on AWS
Apache License 2.0
3 stars 8 forks source link

Default region is hardcoded, other defaults are read from ENV #27

Closed lucjanrudziak closed 4 years ago

lucjanrudziak commented 4 years ago

The default region is hardcoded as 'ap-southeast-2' https://github.com/shinesolutions/ruby_aem_aws/blob/master/lib/ruby_aem_aws/constants.rb#L45

While other constants are read from the ENV values. Maybe the hardcoded value can be the final fallback, if both the config and ENV values are nil?

lucjanrudziak commented 4 years ago

A perfect solution would be to also try to determine the region via AWS api as a fallback...

lucjanrudziak commented 4 years ago

Seems like it's solved in this PR: https://github.com/shinesolutions/ruby_aem_aws/pull/28/commits