search

shinesolutions / swagger-aem

OpenAPI specification for Adobe Experience Manager (AEM) API
Apache License 2.0
37 stars 22 forks source link

Changed usage of cgi.escape to erb::util.url_encode in crx_api.rb cli… #75

Closed ub1k24 closed 3 years ago

ub1k24 commented 3 years ago

Changed usage of cgi.escape to erb::util.url_encode in crx_api.rb client to properly handle spaces in path

cliffano commented 3 years ago

@ub1k24 thank you for spotting this issue. Since the code is part of the generated client, I'll bring this investigation over to openapi-generator project itself.

For the time being, I can confirm that this issue still exists with swagger_aem 3.5.0 which was generated using openapi-generator 4.3.1 .

cliffano commented 3 years ago

Including this in the upcoming release 3.5.0 . However, need to retrofit this as well in openapi-generator. Currently Ruby swagger_aem 3.5.0 will still use openapi-generator 4.3.1 , so we'll need to upgrade to latest openapi-generator 5.x before retrofitting this fix.

cliffano commented 3 years ago

Thanks @ub1k24 for the contribution, sorry it took a long time.