search

shingarov / MachineArithmetic

A mathematical foundation for Smalltalk-25
MIT License
17 stars 6 forks source link

[Z3] Add `Z3BitVectorSort>>#uminVal`, `#umaxVal`, `#sminVal`, `#smaxVal` #294

Open janvrany opened 3 months ago

janvrany commented 3 months ago

This commit adds methods return minimum and maximum values of bitvector of given size - both when interpreted as unsigned and signed values.

shingarov commented 3 months ago

I agree these convenience methods are useful (also for other client code). Still, I would slightly prefer to separate such "our-added API" from "Nikolaj's API" — well, if you think it is worth the trouble. But ultimately I don't have a strong opinion on this: I am ok if you think this PR should be just merged.

shingarov commented 3 months ago

What I still would change, is remove the long part of the commit message: it adds nothing.

janvrany commented 3 months ago

What I still would change, is remove the long part of the commit message: it adds nothing.

Done

Still, I would slightly prefer to separate such "our-added API" from "Nikolaj's API"

Right. Let me think.