search

shinglyu / moztrap-new-ui

A new frontend UI for MozTrap that levarages on its REST API
10 stars 13 forks source link

Cleanup the getInitialState in SearchableListMixin #101

Closed shinglyu closed 9 years ago

shinglyu commented 9 years ago

The two return in if...else... violates the DRY priciple

hitripod commented 9 years ago

I use defaultQuery to avoid violating DRY incidentally, there might be a more graceful solution.

shinglyu commented 9 years ago

LGTM for now. I'm planning to add a user setting to set a default query, so the code may change.