search

shinhancard / dev-portal

Shinhancard developer portal public github repository
Apache License 2.0
9 stars 2 forks source link

Project init complete #53

Closed YOOMYE89 closed 1 year ago

YOOMYE89 commented 1 year ago

Description close #7

Checklist I have explained the need for this PR and the problem it solves I have explained the changes or the new features added to this PR I have added tests corresponding to this change I have updated the documentation to reflect this change I have verified that this change is backward compatible

wijihoon commented 1 year ago 
backstage/cli 적용을 위해 테스트를 해보았지만, 
아래와 같은 이유로 동일한 오류가 지속 발생하였습니다.
현재와 같이 구조를 유지하는게 맞을거 같습니다.

구조

  1. Storybook 또한 package 안으로 넣어서 작업하려고 했으나, 종속성 문제로 하지 않는게 좋을 듯함.

    참고) Why is this not part of @backstage/core-components? This separate storybook package exists because of dependency conflicts with @backstage/cli. It uses nohoist to avoid the conflicts, and since you can only use that in private packages it has to be separated out of @backstage/core-components.

https://github.com/backstage/backstage/tree/master/storybook

hellices commented 1 year ago

https://github.com/backstage/backstage/tree/master/storybook#storybook pass one or more packageyarn storybook plugins/search & nohoist 로 용량을 줄일 수 있지 않을까? 검토

YOOMYE89 commented 1 year ago

rebase 완료 및 모노레포 구성 완료 pass one or more packageyarn storybook plugins/search & nohoist 로 용량을 줄일 수 있지 않을까? -> 처리 완료 각 스토리북은 루트에 있는 pakages / plugins을 참조하고 각 모듈은 workspace:내에서 움직임