manuelzander commented 4 years ago

Summary

Added STRING to BQ_DATA_TYPE_DIC["STRING"] to support schema conversion when DDL contains STRING data type (for example BigQuery DDLs, see https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#string_type).

Added

STRING to BQ_DATA_TYPE_DIC["STRING"]
Unit-test to reflect above

Changed

n/a

Removed

n/a

Fixed

n/a

File Details

`ddlparse/ddlparse.py`

See above

Applicable Issues

63

codecov[bot] commented 4 years ago

Codecov Report

Merging #62 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          390       390           
=========================================
  Hits           390       390

Impacted Files	Coverage Δ
ddlparse/ddlparse.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de3ec0b...be97cf0. Read the comment docs.

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling 813754d95bef76ba7d613f8ac674b016cf5f5f4e on manuelzander:bq-datatype-patch into de3ec0bb2bfebce2105b46763b785dc08b92cdf1 on shinichi-takii:master.