shining-man / bsc_fw

Firmware battery safety controller (BSC)
MIT License
98 stars 19 forks source link

JK BMS V1.3 Support / SOC Calculations based on Min/Max Cell Voltage #49

Closed drakesoft closed 1 year ago

drakesoft commented 1 year ago

JK BMS V1.3 Protocol RS485 Support for JK-B1A24S / JK-B2A24S Balancer SOC Calculations based on Min/Max Cell Voltage

drakesoft commented 1 year ago

I fixed the issues you mentioned.

shining-man commented 1 year ago

Can you possibly add the BMS to the table in BmsData.h? There you can see which data the BMS delivers.

I have seen that you do not fill the bmsErrors and bmsStateFETs or not correctly. This means that the BMS can only be used correctly for monitoring. I will therefore add a comment that the BMS can only be used for monitoring. If the BMS is also to be used for charge control, etc., it also needs all the necessary data (bmsErrors, bmsStateFETs, ...).