Add support for nextcloud 28, 29

C0la149 commented 5 months ago

Hello. I noticed that this plugin breaks the cloud for me. The files cannot be viewed. It just doesn't open. Update the plugin and add support for the new nextcloud. thx

axelmiami commented 4 months ago

I need support for nextcloud 2 too

BenjaminSteimer commented 3 months ago

Good Morning. I am thinking about forking this and making it public since it seems this project is dead. Does anyone have any hints about what would need to be modified to make it work on newer versions?

Happyfeet01 commented 3 months ago

Good Morning. I am thinking about forking this and making it public since it seems this project is dead. Does anyone have any hints about what would need to be modified to make it work on newer versions?

I have the same idea. Maybe to fix some issues with KI help. 🤷🏼‍♂️ Unfortunately I don't have the necessary knowledge

Bl4DEx commented 3 months ago

Hi everyone,

depending on what kind of error you have, here is a little help after I did some research + try and error:

Setup

Nextcloud v29.0.5
PHP v8.3

Error entry in nextcloud.log

After installing the app, I got an Internal Server Error in the nextcloud UI and the the following error in nextcloud.log: AutoloadNotAllowedException Autoload path not allowed: /var/www/nextcloud/apps/ncdownloader/appinfo/application.php

After some try and error (which included to build the vue.js frontend of master branch on my side), it turns out that Nextcloud installed app version v0.9.0 by default. I cannot find this release in Github but it is an old release nevertheless. Later, I noticed that this version is the only "compatible" version of NCDownloader with php v8.3. I am saying "compatible" because this version does not specify a php version at all in appinfo/info.xml which makes Nextcloud think that it is compatible with all php version most likely.

I was not able to force Nextcloud to download the latest release as visible in the App Store Page Nextcloud App Store, which should be v1.0.20 which is also the latest release here in Github.

How I solved it (somewhat)

Get latest release from official Nextcloud App Store yourself. On your server:

Navigate to your nextcloud apps installation path (e.g. /var/www/nextcloud/apps)
Download app archive: sudo curl -L https://github.com/shiningw/ncdownloader/releases/download/v1.0.20/ncdownloader-release.tar.gz -O
Extract archive in-place: tar -xf ncdownloader-release.tar.gz
Modify ncdownloader/appinfo/info.xml / line 22 max-version to 8.3
Move ownership of folder to webserver user: chown www-data:www-data -R ncdownloader
(Cleanup) Remove archive: rm ncdownloader-release.tar.gz

Login as Admin in Nextcloud:

Enable NCDownloader (version should be visible as v1.0.20)
Go to Admin Settings / NCDownloader Settings and check + update yt-dlp (the shipped yt-dlp is v2023.03.04 and seems not to work)
Try it out! (I am using YT-Download only so I can't speak for other features)

Drawback

~~It seems to work for the Admin User only. The UI elements for normal user does not seem to be fully initialized as the searchbar is missing. Any help to figure this one is highly appreciated 😄 Unfortunately, it does not print any error in the nextcloud.log so I am not sure what is missing. I have noticed that impersonating a normal user as an Admin does work. I am not sure what to do with this information but maybe somebody else can figure this one out.~~

It is working fine on my phone for a normal user as well. I am not sure if this was a cache issue on my PC where one of previous attempts was still cached. I will try this tomorrow after clearing browser cache

Happyfeet01 commented 3 months ago

Thanks,

It works now. 😊 But it seems the IP is blocked at Google. 🙄 torrent and http download works fine.

I got this message

[index] Fehler: HTTP/2 404 returned for "https://slider.kz/vk_auth.php?q=Rock". POST /apps/ncdownloader/search von 37.19.195.88 von lars um 26.08.2024, 07:07:10

Happyfeet01 commented 3 months ago

Change the two lines slider.kz to hayqbhgr.slider.kz and it works

Happyfeet01 commented 2 months ago

Merged https://github.com/shiningw/ncdownloader/releases/tag/v1.0.21

genewitch commented 2 months ago

edit: this is true of the 1.0.20 and the 1.0.21 release linked above!

"Start aria2" button still fails; in the nextcloud-data/aria2/aria2.log file it says

"[NOTICE] [TimedHaltCommand.cc:66] 3 second(s) has passed. Stopping application."

I am annoyed that the nextcloud updater did not let me know that this functionality was going to break. Gotta say, it doesn't bode well for my continued usage of NC.

for now, the workaround is to log in via ssh and go to /var/www/nextcloud-data/genewitch/files/Downloads/ aria2c "magnet link" #with quotes! then once it's done to my seeding satisfaction occ files:scan --path=/genewitch/files/Downloads #this makes it appear in the downloads folder when it's done.

note: i use turnkey NC, which uses the turnkey-occ command.

Is the issue with aria2[c], or is the issue with this repo? because there are similar cli apps for bt - i use one on my navidrome server.

shiningw / ncdownloader