shinken-monitoring / mod-webui

Shinken Web User Interface
GNU Affero General Public License v3.0
79 stars 71 forks source link

Use the contact_name rather than alias in the external commands #664

Closed mohierf closed 5 years ago

mohierf commented 5 years ago

Using the get_name() function for the name of the user in the external comands is not consistent ... Nagios / Shinken / Alignak expect the contact_name property and not the display_name nor alias one

maethor commented 5 years ago

Are you sure about this? I don't have time to review it properly, but if it breaks anything in my setup I will revert. And we use external commands a lot.

mohierf commented 5 years ago

@maethor : I am almost 99.99% sure that it will not beak anything, but do not merge yet!

I tested with my Alignak and it is ok but I will make a test with Shinken and I will confirm to you 😉

maethor commented 5 years ago

OK. You can merge by yourself when you think this is fine. I'm ok with it.

mohierf commented 5 years ago

Ok. I will merge after my tests

mohierf commented 5 years ago

Confirmed! One must use the contact_name in some external comands because Shinken searches for an existing contact for some commands