search

shinken-monitoring / mod-webui

Shinken Web User Interface
GNU Affero General Public License v3.0
79 stars 71 forks source link

WiP : Alignak views #671

Closed mohierf closed 5 years ago

mohierf commented 5 years ago

Alignak logs and statistics - first draft as a PoC Some Alignak specific views: livesynthesis, status, events log

1st commit is same as #659 ... needed for Alignak that raises NW broks 3rd commit is same as #670 ... CSS styling for Alignak specific menu

maethor commented 5 years ago

@mohierf since this is Alignak specific I let you merge when this is ready.

maethor commented 5 years ago

Hm, no. Do not merge anything in common css or helpers. Please separate what is alignak specify.

mohierf commented 5 years ago

There is nothing specific in the branch for the CSS ... this is because you did not yet merged #670 .

Adding a function in helper.py will not break the Shinken version ... but I will make an alignak_helper.py file.

mohierf commented 5 years ago

@maethor : I created an alignak_helper.py file for the alignak specific function. This isolates as much as possible the specific code. Note that it still exists some common part in some files but it is not possible to create separate files for everything ....

maethor commented 5 years ago

I don't understand, why do you say "because you did not yet merged #670"? Pull Requests should be independent from each others. Unless there is stuff you need in #670 for this code to work, you should be able to merge this without #670.

mohierf commented 5 years ago

Sure, but I was obliged to include a commit from #670 in this PR to avoid a huge mess ... and to be able to continue working independently on both PR

mohierf commented 5 years ago

@maethor : I am closing this one and I will re-open a new Alignak specific PR. This one is now quite complicated to maintain because of the most merge and many commits since its inception...