search

shinken-solutions / shinken

Flexible and scalable monitoring framework
http://www.shinken-monitoring.org
GNU Affero General Public License v3.0
1.13k stars 337 forks source link

shinken/webui/ directory should be renamed to something more generic #1090

Open rezib opened 10 years ago

rezib commented 10 years ago

The content of shinken/webui/ directory is just a simple class (actually 2 but with almost the same code) used by several shinken modules (including webui module of course, but not only).

The name wrongly mention the webui module and it is not only related to it anymore. For obvious comestic reasons, It should be renamed into something more generic.

This issue should focus into tracking all external modules to relies on these classes.

rezib commented 10 years ago

First found occurrences:

  1. mod-webui module in files:
  2. mod-ws-arbiter module in files:

There is also the setup.py to update.

naparuba commented 10 years ago

ps it's important to have the 2 distrinct even if the code is similar ;)

but not mandatory to be in webui dir if we find a better place

On Fri, Feb 14, 2014 at 11:13 AM, Rémi Palancher notifications@github.comwrote:

First found occurrences:

  1. mod-webui module in files:
    • module/module.pyhttps://github.com/shinken-monitoring/mod-webui/blob/master/module/module.py .
      1. mod-ws-arbiter module in files:
    • module/module.pyhttps://github.com/shinken-monitoring/mod-ws-arbiter/blob/master/module/module.py .

There is also the setup.py to update.

Reply to this email directly or view it on GitHubhttps://github.com/naparuba/shinken/issues/1090#issuecomment-35071344 .

rezib commented 10 years ago

The only relevant diff between the 2 files is:

--- bottlecore.py   2014-02-10 21:43:24.000000000 +0100
+++ bottlewebui.py  2014-02-10 21:43:24.000000000 +0100
@@ -802,8 +802,7 @@
         convenient access methods and properties. Most of them are read-only."""

     #: Maximum size of memory buffer for :attr:`body` in bytes.
-    # SHINKEN: *1000
-    MEMFILE_MAX = 1024000000
+    MEMFILE_MAX = 102400

Do you think we can't avoid from having these 2 big files instead of one?

naparuba commented 10 years ago

nop, if we keep the same, python will manage it like the same lib if another "module" is loading it. And it means that webui will be launched with core / routes, and this is not a good thing :p

so we must have 2 of them, or find a way to make python do not mix the same module file into a same "python module" object in memory (I didn't find how to do this, but maybe it's possible).

On Fri, Feb 14, 2014 at 4:27 PM, Rémi Palancher notifications@github.comwrote:

The only relevant diff between the 2 files is:

--- bottlecore.py 2014-02-10 21:43:24.000000000 +0100+++ bottlewebui.py 2014-02-10 21:43:24.000000000 +0100@@ -802,8 +802,7 @@ convenient access methods and properties. Most of them are read-only."""

 #: Maximum size of memory buffer for :attr:`body` in bytes.-    # SHINKEN: *1000-    MEMFILE_MAX = 1024000000+    MEMFILE_MAX = 102400

Do you think we can't avoid from having these 2 big files instead of one?

Reply to this email directly or view it on GitHubhttps://github.com/naparuba/shinken/issues/1090#issuecomment-35093082 .

Frescha commented 10 years ago

any news or can we close the issue?

naparuba commented 10 years ago

we can keep it but for another release

On Sat, Mar 15, 2014 at 10:48 AM, Andreas Karfusehr < notifications@github.com> wrote:

any news or can we close the issue?

Reply to this email directly or view it on GitHubhttps://github.com/naparuba/shinken/issues/1090#issuecomment-37721774 .