shinnn / is-vfile-message

Check if a value is a VFileMessage object
MIT License
1 stars 0 forks source link

Things #1

Open wooorm opened 8 years ago

wooorm commented 8 years ago

Nice work @shinnn!

Looks like quite the test haha! Are you sure you need to be so thorough? Most important is (existence of) line, column, reason, and fatal.

I’m not sure if you’re goal was to check for actual values created by VFile#warn and VFile#fail, or anything which “should” be correctly handled by vfile-related tools. If the later, I tried to be quite forgiving in, for example, vfile-reporter, which also supports messages without fatal and treats them as informative messages, instead of warnings or failures.

It probably all depends on what you’re trying to do (I’m quite interested) though! :+1:

Bye :smile:

wooorm commented 8 years ago

@shinnn Ping!