fix: allow placeholder in table search

shinokada / svelte-5-ui-lib

A UI library crafted for Svelte 5: Runes

https://svelte-5-ui-lib.codewithshin.com

MIT License

104 stars 13 forks source link

fix: allow placeholder in table search #17

Closed blazef104 closed 2 months ago

blazef104 commented 2 months ago

📑 Description

Currently the placeholder is not passed through in the table search bar.

✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[x] I have updated the documentation as required
[ ] All the tests have passed

vercel[bot] commented 2 months ago

@blazef104 is attempting to deploy a commit to the Shinichi Okada's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
svelte-5-ui-lib	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 11, 2024 3:23pm

shinokada commented 2 months ago

Since it is extending HTMLTableAttributes, you can add any attributes to TableSearch. It is better not to add unnecessary attributes.

blazef104 commented 2 months ago

@shinokada I was more trying to fix the placeholder not being passed through to the input. I believe that is still not passed through. Am I doing something completely wrong?

shinokada commented 2 months ago

Thank you for your PR.