search

shinokada / svelte-5-ui-lib

A UI library crafted for Svelte 5: Runes
https://svelte-5-ui-lib.codewithshin.com
MIT License
104 stars 13 forks source link

Installation instructions not correct #22

Closed Hugos68 closed 1 month ago

Hugos68 commented 1 month ago

Describe the bug

In the installation instructions it states to set runes to true in compileroptions but this is not needed and actually probably bad advice as it will force all your deps to be svelte 5 syntax otherwise it won't compile. If svelte sees you're using runes it will dynamically compile with or without runes, so ideally this step in the installation instructions is removed.

Reproduction

not relevant

Version and System Info

not relevant
shinokada commented 1 month ago

Thanks. It used to be required to run Runes. I will check it and update the doc.

shinokada commented 1 month ago

Since it is in the Svelte 5 preview doc, I will rephrase it. I found that flowbite-svelte-icons breaks by removing it.