search

shinokada / svelte-5-ui-lib

A UI library crafted for Svelte 5: Runes
https://svelte-5-ui-lib.codewithshin.com
MIT License
108 stars 13 forks source link

Table component click events and transitions #26

Open larryh-23andme opened 1 month ago

larryh-23andme commented 1 month ago

Describe the bug

Hi, thanks for this library! I noticed the table component isn't working as expected for the example "Click double click". Double-click seems to compete with the click event, so it isn't clear what is supposed to happen. But more importantly, when clicking a table row it opens the detail row as expected, but does not use transitions when given. The example on your site includes transitions but I don't see it activated when clicked. Nor does it work when I use my own instance with different slide params with easing, etc. No errors produced. Thanks!

Reproduction

https://svelte-5-ui-lib.codewithshin.com/components/table using the "Click double click" example.

Version and System Info

System:
    OS: macOS 14.6.1
    CPU: (11) arm64 Apple M3 Pro
    Memory: 58.69 MB / 18.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.17.0 - ~/.nvm/versions/node/v20.17.0/bin/node
    npm: 10.8.2 - ~/.nvm/versions/node/v20.17.0/bin/npm
    pnpm: 9.10.0 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 129.0.6668.71
    Safari: 17.6
  npmPackages:
    @sveltejs/kit: ^2.5.28 => 2.5.28 
    svelte: 5.0.0-next.256 => 5.0.0-next.256 
    svelte-5-ui-lib: ^0.9.11 => 0.9.11 
    vite: ^5.4.6 => 5.4.6
shinokada commented 1 month ago

Yes, it is in the todo list. https://svelte-5-ui-lib.codewithshin.com/pages/coverage

image