search

shinokada / svelte-heros-v2

Hero Icons v2 for Svelte. You can select outline and solid icons using the variation props. Svlete-Heros support major CSS framework. You can add additional CSS using the `class` props.
https://svelte-heros-v2.codewithshin.com
Apache License 2.0
41 stars 3 forks source link

[BUG]: Solid Icons are not solid filled #19

Closed dorisip closed 1 year ago

dorisip commented 1 year ago

Description of the bug

Solid icons are no longer solid fill.

image

Steps To Reproduce

  1. Pick the Star Icon
  2. The Solid variation is not filled
<Icon name="star-solid" class="text-green-500" />

I'm trying to upgrade to v 0.8.2 and is seeing this regression.

Additional Information

No response

shinokada commented 1 year ago

Thank you for letting me know this. I will fix it asap.

shinokada commented 1 year ago

Can you update it to the latest version and let me know? Since API has changed, please read the doc at https://svelte-heros-v2.vercel.app/.

dorisip commented 1 year ago

Looks good to me. Thanks

dorisip commented 1 year ago

Separate issue though - strokeWidth doesn't get bubble down properly

image
shinokada commented 1 year ago

You are right. I will remove stroke-width from the exports.