shinyaohtani / giturl

Open GitHub URL for given directory

MIT License

5 stars 1 forks source link

Feature/#2 support windows linux #17

Closed shinyaohtani closed 4 years ago

shinyaohtani commented 4 years ago

Support for Windows and Linux using Launchy

Issue #2
- Launchy is used for launching browsers.
- Launchy is used on OS other than macOS and on macOS when no browser is specified.
- In other words, system ('open') is only called directly on macOS and when browser is specified. Even if it is macOS, Launchy will launch the browser if there is no browser specification.
  - Not macOS ==> Launchy.open(url)
  - macOS without --app ==> Launchy.open(url)
  - macOS with --app ==> system('open -a ... url')
- **Since Launchy module does not support browser specification at all, on macOS and when specifying --app, I decided to usesystem ('open') directly instead of Launchy.open().