search

shinyaohtani / giturl

Open GitHub URL for given directory
MIT License
5 stars 1 forks source link

Introduce Rubocop-performance for readability #23

Closed shinyaohtani closed 4 years ago

shinyaohtani commented 4 years ago

Some bad description were found.

-        @params[:open] = true if @params.keys.include?(:app)
+        @params[:open] = true if @params.key?(:app)
-      baseurl = remote_origin_url.gsub(/:/, '/').gsub(/^.*@/, 'https://').gsub(/\.git$/, '')
+      baseurl = remote_origin_url.tr(':', '/').gsub(/^.*@/, 'https://').gsub(/\.git$/, '')