search

shinyblink / sled

Satanic/Sexy/Stupid/Silly/Shiny LED matrix controller
https://shinyblink.github.io/sled/
ISC License
121 stars 25 forks source link

out_net: Initial commit. #121

Closed esden closed 3 years ago

esden commented 3 years ago

This is a raw RGB 888 data to tcp/udp/unix socket output module. This is derived and based on the out_udp module.

This output module is meant to be compatible with the Glasgow WS2812 video applet.

It should be possible to fold the functionality of out_udp into this module too, but I ran out of time.

To merge in the out_udp functionality one would have to do the following:

More discussion might be necessary to merge the two output modules back together.

vifino commented 3 years ago

As I wrote already in the Discord, this is mighty impressive stuff! From a quick look, this looks quite good!

I'll add some comments in a bit.

Merging the out_udp module with this seems like a lot of effort for little gain, I'm fine with this as-is.

Now I definitly need to get a glasgow! ;)

fridtjof commented 3 years ago

This looks good to merge, save for the codacy check? (tbh, should we just ditch codacy?)

vifino commented 3 years ago

@fridtjof Sure, lets ditch it.

The reason this is not merged yet because I've not tried it. esden mentioned that he had a simulator in the works, but since it's known working, we could probably just merge it now.

fridtjof commented 3 years ago

Codacy thrown out, merging it now