search

shinyblink / sled

Satanic/Sexy/Stupid/Silly/Shiny LED matrix controller
https://shinyblink.github.io/sled/
ISC License
122 stars 25 forks source link

flt_scale and out_sdl2 do not work together #8

Closed marenz2569 closed 6 years ago

marenz2569 commented 6 years ago

see vifino/sled#7 for more information.

vifino commented 6 years ago

Could you rebase your changes on master so we get a clean commit? You can force push to your fork to update this PR.

marenz2569 commented 6 years ago

After some git voodoo (rebase and reset --hard and push --force) this is now only one commit.

vifino commented 6 years ago

Nice! If you would address the remaining comments (out_sdl2, other modules and keeping the multiplication-outside-of-loop), then this is ready to go.

vifino commented 6 years ago

Actually, I'll just merge it now, I'll do the changes I suggested. Many thanks!