search

shinydevelopment / SimulatorStatusMagic

Clean up your status bar for taking screenshots on the iOS simulator.
MIT License
2.35k stars 140 forks source link

Excluding from App Store builds with SPM #102

Closed daveverwer closed 2 years ago

daveverwer commented 2 years ago

I don't know whether any of you saw this article from Toomas Vahter recently?

I wondered if it might solve the problem of SimulatorStatusMagic and release/App Store builds? It seems like it might. I'm opening this as an issue because it might make a good addition to the README file if it does indeed solve the problem.

chrisvasselli commented 2 years ago

Thanks, I didn't see that. I'll give it a shot and see how it works. 👍

chrisvasselli commented 2 years ago

After looking at it, my initial reaction is to not add this to the README as an approach for disabling SimulatorStatusMagic. I think we could get this approach working, but it has some drawbacks. For one, it would break the ability for people to choose to link SimulatorStatusMagic in any build that doesn't define DEBUG, which could break existing users integrating via Cocoapods/Carthage. And since it requires using a wildcard to exclude certain files from the build based on path, it feels more complicated to setup and a little more error-prone.

I'd tend to leave the current approach of linking to the UI target as the recommended way of integrating via SPM.

@nrbrook any thoughts?

nrbrook commented 2 years ago

@chrisvasselli by ui target do you mean UI test target? I would agree that should be the suggested approach.

chrisvasselli commented 2 years ago

@nrbrook Yes, sorry I mean the UI test target. Sounds like we're on the same page.

@daveverwer thanks for sharing this! I'm going to close out this issue.

daveverwer commented 2 years ago

No problem! Thanks for taking a look!