search

shinydevelopment / SimulatorStatusMagic

Clean up your status bar for taking screenshots on the iOS simulator.
MIT License
2.35k stars 140 forks source link

Add framework target #27

Closed shritekale closed 8 years ago

shritekale commented 9 years ago

This PR allows us to build the code as a dynamic framework to link into apps that don't use CocoaPods. Should give carthage support for free as well, for people going that route.

daveverwer commented 9 years ago

Looks good and I'd be happy for this to be merged. Might be worth a mention in the README if you want to add something?

shritekale commented 9 years ago

@daveverwer Updated README file.

daveverwer commented 9 years ago

I'll get this merged at the weekend, thanks very much for the contribution!

shritekale commented 8 years ago

This would lead to potential app rejection from Apple since the library built is universal for simulator and device. Therefore closing this PR without merging.

dbmrq commented 8 years ago

@shritekale Carthage has a Run Script Build Phase to fix that problem and it would be nice to have Carthage support.

daveverwer commented 8 years ago

Apologies, I never did respond to this after the original PR. I'd be happy to merge this if someone can prep it (my knowledge of Carthage is not great).

shritekale commented 8 years ago

@danielbmarques In that case, I will reopen this.

dbmrq commented 8 years ago

@shritekale @daveverwer Great, thank you. :) I don't know much about Carthage myself, I have just begun using it, but they talk about the script I mentioned here, and it seems to address precisely the issue you pointed out.

shritekale commented 8 years ago

@danielbmarques @daveverwer My apologies as I should have been more clear. Apart from the issue you have mentioned, there is a possibility of app rejection because of the private api used in the code. Anyone who consumes the dynamic framework, will be linking against both simulator and device and may submit their apps to the App Store with the framework embedded. Perhaps we need to update the README here to make it clear?

dbmrq commented 8 years ago

@shritekale Oh, I see. Well, I still think it would be worth it. I don't use CocoaPods, so right now I'm copying the whole source code, and when I archive my app I remove it from my Compile Sources and comment it out from the code, and when I need it I add it back to the sources and uncomment it again. Just adding or removing a framework would be a lot more convenient, it just has to be clear in the readme.

dbmrq commented 8 years ago

@shritekale @daveverwer Or maybe we could do this, if I understood correctly?