search

shinydevelopment / SimulatorStatusMagic

Clean up your status bar for taking screenshots on the iOS simulator.
MIT License
2.35k stars 139 forks source link

property to show/hide battery percentage #46

Closed mouhassan closed 7 years ago

mouhassan commented 7 years ago

I added a property to show/hide battery percentage.

I had to do a workaround because setting percentage to empty string @"" doesn't work. so I had to set to one space @" " and update the status bar, then set to empty string and update again.

daveverwer commented 7 years ago

Thanks for this @mouhassan, cleaned up and merged.

mouhassan commented 7 years ago

Thanks Dave.

I just wanted to highlight that the default behaviour now is that battery percentage is not shown unless the property is set explicitly to TRUE. So, is that ok? or should I change the default behaviour to always show the battery percentage unless explicitly turned off?

daveverwer commented 7 years ago

I changed that in my cleanup.

https://github.com/shinydevelopment/SimulatorStatusMagic/commit/45ab03af63b8ab06b516c3ac2d9c1054aaeaeb62

mouhassan commented 7 years ago

Thanks Dave for clarification. I'm glad I got a chance to contribute something to this awesome project.

daveverwer commented 7 years ago

Thanks for helping!

I just pushed 1.9.3 to Cocoapods so it should be available there soon.