Implement status bar data overrider for iOS 12b1

shinydevelopment / SimulatorStatusMagic

Clean up your status bar for taking screenshots on the iOS simulator.

MIT License

2.35k stars 140 forks source link

Implement status bar data overrider for iOS 12b1 #64

Closed cysp closed 6 years ago

cysp commented 6 years ago

😃

I left the changes from iOS 11 as a separate commit for easier review.

daveverwer commented 6 years ago

Thanks for this! I'm seeing a little weirdness when testing this with the iOS 12 beta:

It seems to switch the Airplane mode icon on
It causes the Bluetooth headphone icon to appear
Change the time or carrier doesn't work
Changing the Network status doesn't work
Switching Bluetooth to dimmed or connected causes the battery icon to appear next to the headphones.

Thanks so much for making a start on this but I'll not merge it until these are fixed.

daveverwer commented 6 years ago

cysp commented 6 years ago

Odd. I saw exactly those issues before I changed the indexes within StatusBarItem but the current branch here allows changing of all of those items on my machine. 🤔

cysp commented 6 years ago

daveverwer commented 6 years ago

I just tested it again and I don't quite know what happened but it now works for me. I'd say I was on the wrong branch, but I didn't even change branches before re-running it.

I'll get it merged!

daveverwer commented 6 years ago

Thank you for this!