Method Send(Notification notification) in android implementation of INotificationManager was storing shared type of Notification in repository, now it will store Android Notification.
Issues Resolved
fixes #1406
API Changes
None
Platforms Affected
Android
Behavioral Changes
Now scheduled notifications should appear for the user on android platform.
Testing Procedure
Don't know what to say just try to notificationManager.Send(notification) on android with ScheduleDate with and without this fix.
Description of Change
Method
Send(Notification notification)
in android implementation ofINotificationManager
was storing shared type ofNotification
inrepository
, now it will storeAndroid Notification
.Issues Resolved
API Changes
None
Platforms Affected
Behavioral Changes
Now scheduled notifications should appear for the user on android platform.
Testing Procedure
Don't know what to say just try to
notificationManager.Send(notification)
on android withScheduleDate
with and without this fix.I recorded also video before and after fix:
https://github.com/shinyorg/shiny/assets/10498621/774a0d56-702c-4da9-af15-6e46276f9300
https://github.com/shinyorg/shiny/assets/10498621/8f7bacea-9123-418e-b15e-69ec711a9aa9
PR Checklist