shinyorg / shiny

.NET Framework for Backgrounding & Device Hardware Services (iOS, Android, & Catalyst)
https://shinylib.net
MIT License
1.43k stars 227 forks source link

Fix for sending scheduled local notifications #1458

Closed anchorit3 closed 4 months ago

anchorit3 commented 4 months ago

Description of Change

Method Send(Notification notification) in android implementation of INotificationManager was storing shared type of Notification in repository, now it will store Android Notification.

Issues Resolved

API Changes

None

Platforms Affected

Behavioral Changes

Now scheduled notifications should appear for the user on android platform.

Testing Procedure

Don't know what to say just try to notificationManager.Send(notification) on android with ScheduleDate with and without this fix.

I recorded also video before and after fix:

https://github.com/shinyorg/shiny/assets/10498621/774a0d56-702c-4da9-af15-6e46276f9300

https://github.com/shinyorg/shiny/assets/10498621/8f7bacea-9123-418e-b15e-69ec711a9aa9

PR Checklist

aritchie commented 4 months ago

Thank you for the PR. This does fix an issue, but it doesn't fix the overall issue with the latest API levels.