exclude all inactive descriptions from bundle answer

shinyoshiaki / werift-webrtc

WebRTC Implementation for TypeScript (Node.js), includes ICE/DTLS/SCTP/RTP/SRTP/WEBM/MP4

MIT License

469 stars 30 forks source link

exclude all inactive descriptions from bundle answer #339

Closed benharp closed 12 months ago

benharp commented 1 year ago

Fix to solve #337.

When building the SDP for a negotiation answer, werift includes all media descriptions, including inactive ones, in the BUNDLE description. This PR would make werift only include non-inactive descriptions, which seems to match the behavior of browser WebRTC implementations and werift's offer construction logic.

This repo can create an example of the specific problem I was running into:

https://github.com/benharp/werift-mvb

koush commented 1 year ago

I'm activating/deactivating media tracks extensively and submitted recent changes in this code. I'll see if this change breaks things on my end.

koush commented 12 months ago

No issues on my end so far.

shinyoshiaki commented 12 months ago

@benharp Thanks for your contribution!

benharp commented 12 months ago

Thank you both for this wonderful implementation! Glad I could help.