Open darthbdaman opened 2 years ago
Hey, @shinyquagsire23
I started working on 1 and 2 and everything is fine so far except that I am currently re using existing buttons in the setup menu.
If I understand it correctly a lot of the memory locations are pre-defined by using the original memory layout that the game had, correct?
Now I want to add one button to an existing menu, which has 39 entries. Should I move the variable for the corresponding menu out of the symbols and create it by hand so that the memory gets statically allocated and Is not fixed to an address and use this instead? Or should I "play around" with the symbols file to find a fitting location that has enough space for the menu
@annoo Definitely don't play with the symbols file lol, menus actually already had issues with blobbed execution so all menu items are stored in new memory no matter what (the symbol addresses don't actually get used on 64-bit, but it's useful for regression tests and finding MoTS changes)
For new menu items what I do is set the array size to the maximum possible with all ifdefs enabled, and then if it's an existing menu just put entries in a QOL_IMPROVEMENTS ifdef. I'd suggest putting 2 under General > Advanced that I added, maybe 1 as well? It's kind of a grab-bag area of settings.
Would it be possible to tweak the crosshair size and add an option for it to be smaller?
Would it be possible to tweak the crosshair size and add an option for it to be smaller?
I'd be quite keen for this.
@AlJoelson I haven't added it to the UI yet, but there is a setting for it now if you open your player profile
Expansions & Mods > Open Resource Folder > Navigate to players/YOUR_NAME/ > open openjkdf2.json in Notepad and edit the crosshair scale setting from 1.0 to whatever else.
@shinyquagsire23 I didn't had that much time the last few months, but i've implemented the checkboxes now and added a PR:
https://github.com/shinyquagsire23/OpenJKDF2/pull/241
The settings are also saved to the config json :) I will try to do the scale slider in the next few days if everything is fine with the pr
These are a few enhancements I think would be beneficial.