search

shinyquagsire23 / OpenJKDF2

A cross-platform reimplementation of JKDF2 in C
Other
501 stars 41 forks source link

[Feature Request] Automatic updates #194

Closed Vortikai closed 1 year ago

Vortikai commented 1 year ago

Optional automatic updates for OpenJKDF2. Why not?

shinyquagsire23 commented 1 year ago

Yeah this is definitely something I've needed for a while, definitely before I pull MoTS out of Beta status

Vortikai commented 1 year ago

It would be an opportune time. I just updated the guides for JKGFXMOD on Steam for both JK and MOTS to use OpenJKDF2/OpenMOTS instead due to its simpler installation procedure, despite this being beta software, with warnings it is still in beta. I think this is a good move overall as it gives us more beta testers, and OpenJKDF2 is more user-friendly. The benefits outweigh the negatives of occasional minor issues.

However, those installing it will probably be stuck with the version when they installed it, then later down the line when they return for a session might run into an issue solved by an updated version.

shinyquagsire23 commented 1 year ago

Implemented v0.8.16, it uses Github's Releases API endpoint to check for updates. I also tried to make it fairly futureproof'd from the standpoint of like, if someone made a specific fork of OpenJKDF2 (or if my Github got nuked somehow), it can also point to different repos or mirrored JSONs.

Vortikai commented 1 year ago

That's really cool. My only concern is this probably doesn't work for how I got users installing OpenJKDF2 for Steam.

Currently, we rename openjkdf2-64.exe to JediKnight.exe so that we may launch through Steam and get the Steam overlay. I am assuming the autoupdates will not detect this anomaly, and install as normal? If so, any thoughts on how to mitigate this if possible?

shinyquagsire23 commented 1 year ago

@Vortikai ok the good (bad?) news is that I messed up my automatic updating on Win64 anyhow so the first real working autoupdate will have a fix for that now, lol

Vortikai commented 1 year ago

Most excellent. I assume this takes into consideration the naming conventions of Mysteries of the Sith on Steam being JediKnightM.exe instead of JediKnight.exe.

I'll close this for now and if I run into problems with the MOTS directory/install/updates, I'll open a new one. Thanks a bunch for finally getting this implemented!

shinyquagsire23 commented 1 year ago

Yeah it uses whatever name the EXE was launched as, it's completely invariant. So JK.EXE, JediKnightM.exe, whatever.exe will all get updated from OpenJKDF2-64.exe in the update zip.