search

shinyquagsire23 / SaltySD

A collection of SD redirect patches for 3DS games
74 stars 14 forks source link

Custom menu Music for Smash doesn't work instantly #25

Closed AkitoCL closed 6 years ago

AkitoCL commented 7 years ago

After the title screen, any of the two original menu themes will play. The custom music will play when returning to the Character Select screen after a fight or in the vault. Not sure if this is a Saltysd issue or a game related issue.

SUOlivia commented 7 years ago

That's not a SaltySD related issue, rather an issue with your nus3bank, iirc it's because there's two starting points in the menu theme

On Jan 8, 2017 20:17, "AkitoCL" notifications@github.com wrote:

After the title screen, any of the two original menu themes will play. The custom music will play when returning to the Character Select screen after a fight or in the vault. Not sure if this is a Saltysd issue or a game related issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/shinyquagsire23/SaltySD/issues/25, or mute the thread https://github.com/notifications/unsubscribe-auth/APhmeHzCdPvhC4OizZ3YyngSoBxigVEXks5rQYrCgaJpZM4Ld3lP .

AkitoCL commented 7 years ago

Weird, I'm running out of ideas. I've downloaded the menu nus3bank files countless times and it's the same. I even tried different songs.

SUOlivia commented 7 years ago

That's not the issue, you need to inject the song into the nus3bank

On Jan 8, 2017 22:04, "AkitoCL" notifications@github.com wrote:

Weird, I'm running out of ideas. I've downloaded the menu nus3bank files countless times and it's the same. I even tried different songs.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/shinyquagsire23/SaltySD/issues/25#issuecomment-271203890, or mute the thread https://github.com/notifications/unsubscribe-auth/APhmeBlZz-yUWipDI8xBoEueqq_eNsPfks5rQaPNgaJpZM4Ld3lP .

AkitoCL commented 7 years ago

I just tried that now and also didn't work.

Again, the original music plays in the menu but in the vault it plays just fine. The only difference now is that it doesn't even play after matches now.

Edit: Wait, news flash. SOMETIMES when it returns after a match the custom music plays but it'll never play after the first time you get past the title screen, just the original themes.

It's weird. After launching the game for the first time it'll just play the original themes but after matches, once you return to the Chara Select screen it'll always play both custom themes, even after returning to the title.

shinyquagsire23 commented 7 years ago

https://github.com/shinyquagsire23/SaltySD/blob/master/smash/sdsound.asm#L6 is all I have for custom music so there's not a whole lot that can go wrong there I don't think. There might just be param files which need editing for music to work 100%.