search

shinyworks / cookies

Use Browser Cookies with 'shiny'
https://shinyworks.github.io/cookies/
Other
32 stars 4 forks source link

Add missing parameter to get (Close issue #38) #39

Closed jnolis closed 1 year ago

jnolis commented 1 year ago

This closes issue #38 by adding a missing field to get and extract.

Previously the default behavior for missing values was to return an NA, this PR changes the default behavior to returning a NULL. NULL is more in line with R convention for extracting a missing value (like a nonexistent entry in a list, for instance). So this does break existing behavior, but since the missing field exists if people want the NA they can easily set it back.

jonthegeek commented 1 year ago

I have a PR started to implement this but then I got laid off and time slipped away. Thanks, I'll hopefully merge this in the morning!