Does W command work? - Githubissues

shioyadan / Konata

Konata is an instruction pipeline visualizer for Onikiri2-Kanata/Gem5-O3PipeView formats. You can download the pre-built binaries from https://github.com/shioyadan/Konata/releases

BSD 3-Clause "New" or "Revised" License

383 stars 34 forks source link

Does W command work? #8

Closed mrBitman closed 1 year ago

mrBitman commented 1 year ago

Could you help me - it seems like W command does not work, i don't see any arrows. What am I doing wrong?

//--------------------------------------
I   3   4   0
L   3   0   main_comment: test_3
S   3   0   st_3
C   5           
R   3   104 0
I   4   4   0   
L   4   0   main_comment: test_4
S   4   1   st_4
I   5   5   0   
L   5   0   main_comment: test_5
S   5   2   st_5
I   6   6   0   
L   6   0   main_comment: test_6
C   2
S   6   3   st_6
R   5   191 1
C   7
E   5   2   st_5

W   5   6   0  // arrows???

C   6

shioyadan commented 1 year ago

Dependency arrows are shown between stages with "X" in the stage name. Please try to make stages with "X" in the stage name. I forgot to mention this in the documentation, so I will add it to the documentation. Thanks!

mrBitman commented 1 year ago

I made X-name by stages 4 and 6, but nothing happened

I   3   4   0
L   3   0   main_comment: test_3
S   3   0   st_3    
C   5           
R   3   104 0   

I   4   4   0   
L   4   0   main_comment: test_4
S   4   1   X // X-name too

I   5   5   0   
L   5   0   main_comment: test_5
S   5   2   st_5
I   6   6   0   

L   6   0   main_comment: test_6
C   2
S   6   3   X  // X-name 
R   5   191 1

C   7
E   5   2   st_5
W   6   4   0 // waiting dependence between 6 and 4
C   6

shioyadan commented 1 year ago

To show dependency arrows, "X" stages must be closed by the "E" command or another successor stage must be started. I added the "E" commands for ID 4 and 6 in the following example.
The consumer and producer arguments for the "W" are reversed in your trace.

You can see debug messages, which may include parsing errors or warnings, in the console in DevTool. You can enable DevTool from Help -> Toggle DevTool.

Kanata  0004
I   3   3   0
L   3   0   main_comment: test_3
S   3   0   st_3    
C   5           
R   3   104 0   
I   4   4   0   
L   4   0   main_comment: test_4
S   4   0   X
I   5   5   0   
L   5   0   main_comment: test_5
S   5   0   st_5
I   6   6   0   
L   6   0   main_comment: test_6
C   2
E   4   0   X
S   6   0   X
R   5   5   1
C   7
E   5   0   st_5
E   6   0   X
W   6   4   0
C   6

shioyadan commented 1 year ago

Lane id must be consistent in each instruction (typically they should be zero). Otherwise, the instruction stages are not closed properly. You used inconsistent lane id in each instruction in your trace.

mrBitman commented 1 year ago

Thank you for your answers! I got arrows in my visualisation!

I thought that just affects on a color of stage-block. Could you explain me what is and how does i need to use it properly?

shioyadan commented 1 year ago

Congratulations! I added some detail to the document. Please see the following part. https://github.com/shioyadan/Konata/blob/master/docs/kanata-log-format.md#lane