make sure that the advance_notice service only gets booked if we can …

shipcloud / shipcloud-for-woocommerce

shipcloud for WooCommerce

GNU General Public License v3.0

6 stars 0 forks source link

make sure that the advance_notice service only gets booked if we can … #173

Closed andrecedik closed 6 years ago

andrecedik commented 6 years ago

…determine the language

fixes #172

What has changed?

We're now checking to see if we were able to determine the language before adding advance_notice to a shipment request.

Things to review

Common things:

[x] Works fine.
[x] Changelog written or not needed.
[x] No conflict with current branch.

andrecedik commented 6 years ago

Hey @ScreamingDev or @mahype I'd really love to see a test that covers this issue. Unfortunately I don't have a working test environment right now. Could you please add a test for me? 🙏 That would be great. 💪