Enhancements

[flav-code]

Minor improvement

Added Rest.getLavalinkInfo() and his type

https://github.com/lavalink-devs/Lavalink/blob/master/IMPLEMENTATION.md#get-lavalink-info

[flav-code]

well, I made the function to avoid duplicating coe but you can add an argument for when you need to disconnect the bot or set channel_id to null before calling the function.

[Deivu]

I just dont really turn it to null before in a case you want to reconnect, but I guess that should be on developer's responsibility eh?

[flav-code]

That's why I didn't put the function for disconnect, I only put it where it's the same.

[Deivu]

Yeah, but I'm thinking if we should let the developer do that instead, after all I think anything outside the scope of lavalink & discord api should be in developer's responsibility, not our responsibility. I'll re-review once decided.

[flav-code]

but what are you talking about

[Deivu]

Reset every data in the connection class, before calling this.sendVoiceUpdate(), so it's up to the developer's (user) responsibility to cache the existing data

[flav-code]

so in disconnect you call the function and you want the user to delete the channel_id before calling the disconnect function?

[Deivu]

so in disconnect you call the function and you want the user to delete the channel_id before calling the disconnect function?

Tldr:

this.channel_id = null;
this.deafened = false;
this.muted = false;
this.sendVoiceUpdate();
// ... rest of the code in disconnect

[flav-code]

That's what I wanted to do... Is that all right with you? Shall I add it?

[Deivu]

For now yeah, as I stated above.

Yeah, but I'm thinking if we should let the developer do that instead, after all I think anything outside the scope of lavalink & discord api should be in developer's responsibility, not our responsibility. I'll re-review once decided.

To keep things simple and concise

[flav-code]

Okay, but this is just to make the code simpler and it won't change anything for the user.

[Deivu]

probably kek, if they dont cache channel id and on closed event, they get the channelid from this class, then sure it will break, but then again, im passing the responsibility of caching this to them now

[flav-code]

Oh okay, I get it, I'm actually using the Connection.channelId

[flav-code]

lol

[flav-code]

good