search

shipgirlproject / Shoukaku

A stable, powerful and updated wrapper around Lavalink
https://guide.shoukaku.shipgirl.moe/
MIT License
273 stars 84 forks source link

Fix: emit shoukaku type. #181

Closed EvilG-MC closed 2 months ago

EvilG-MC commented 2 months ago

This should solve the type en problem: #179

I manually added the type for some reason, it takes the type of the EventEmitter, but in my case the method does not appear, so it was added manually, in Shoukaku.ts and also in Player.ts.

KagChi commented 2 months ago

Do not ignore pnpm lockfiles

EvilG-MC commented 2 months ago

Do not ignore pnpm lockfiles

I just followed the fact that the package-lock.json is in the gitignore

KagChi commented 2 months ago

package-lock.json are not required if we use pnpm

EvilG-MC commented 2 months ago

package-lock.json are not required if we use pnpm

My point is that I don't even want to have to force you to use a specific package manager, just the one you want.

Deivu commented 2 months ago

https://github.com/shipgirlproject/Shoukaku/issues/179#issuecomment-2198244783

Is the pr tested, seems like the issue persist till now

EvilG-MC commented 2 months ago

#179 (comment)

Is the pr tested, seems like the issue persist till now

It's quite strange, I tried it locally, because as I mentioned, in my case emit did not appear both in the npmjs version and in the commit where the reverse was made

EvilG-MC commented 2 months ago

I'm going to try again, because it's quite strange