0t4u
commented
1 month ago Why tabs? We do 4 spaces for all of our other repos?
On Sun, 11 Aug 2024 at 10:21, Saya @.***> wrote:
@.**** requested changes on this pull request.
In eslint.config.mjs https://github.com/shipgirlproject/Shoukaku/pull/188#discussion_r1712875132 :
- // await augu.typescript(),
- stylistic.configs['disable-legacy'],
- {
- languageOptions: {
- parserOptions: {
- projectService: true,
- tsconfigRootDir: import.meta.dirname
- }
- },
- plugins: {
- @.***': stylistic
- },
- rules: {
- @.***/semi': [ 'error' ],
- @.***/member-delimiter-style': [ 'error' ],
- @.***/indent': [ 'error', 4, { 'SwitchCase': 1 }],
Use tabs for indents
On eslint.config.mjs https://github.com/shipgirlproject/Shoukaku/pull/188#discussion_r1712875776 :
We should consider moving our eslint config to a dedicated repo so we can keep the coding style consistent through out our ts and js projects
Can be left for future, but something we need to do
— Reply to this email directly, view it on GitHub https://github.com/shipgirlproject/Shoukaku/pull/188#pullrequestreview-2231727523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOYR3RRM5BAZXAZNOUNWYHDZQ3DDFAVCNFSM6AAAAABMJUN2ECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZRG4ZDONJSGM . You are receiving this because you authored the thread.Message ID: @.***>
Deivu
Update the old eslintrc file to the new flat config format, rework eslint config, and lint all files.