search

shipgirlproject / Shoukaku

A stable, powerful and updated wrapper around Lavalink
https://guide.shoukaku.shipgirl.moe/
MIT License
287 stars 86 forks source link

Typings and other minor changes #60

Closed itsmishra19 closed 3 years ago

itsmishra19 commented 3 years ago

Please check it thoroughly before merging, as it contains some breaking changes

Deivu commented 3 years ago

The breaking change on the TrackList must be removed, as that would break semver, aka the old structure must remain there. raw on Track will never be null, nor the info property for it, so the ? is not really needed there

The TrackList change however can be implemented in v3 but that isn't happening yet. Other than that this is fine

itsmishra19 commented 3 years ago

The breaking change on the TrackList must be removed, as that would break semver, aka the old structure must remain there. raw on Track will never be null, nor the info property for it, so the ? is not really needed there

The TrackList change however can be implemented in v3 but that isn't happening yet. Other than that this is fine

Alright wait for few sec

itsmishra19 commented 3 years ago

Ok check it again and lemme know if there's any issue

Deivu commented 3 years ago

Seems ok thanks for the pr