fix(types): export some class and typings

shipgirlproject / Shoukaku

A stable, powerful and updated wrapper around Lavalink

https://guide.shoukaku.shipgirl.moe/

MIT License

287 stars 86 forks source link

Closed noxzym closed 3 years ago

noxzym commented 3 years ago

This PR has been tested

Deivu commented 3 years ago

Merge the fix for TS in the latest commits of the lib, and if this is tested then I can merge it

Deivu commented 3 years ago

Could you give me a rundown of what was changed here? a summary

noxzym commented 3 years ago

Could you give me a rundown of what was changed here? a summary

[x] Move all typings into one files for typings optimization;
[x] Fix missing export ShoukakuTrack and ShoukakuTrackList type;
[x] Type of ShoukakuTrackList#type can be NO_MATCHES or LOAD_FAILED if not get any track or failed to get some track;
[x] Strictly parameter search in method ShoukakuRest#resolve and only return ShoukakuTrackList;

~Actually I want to unify all the typing to make it better, how do you think?~

Deivu commented 3 years ago

Ok, last thing, is this tested and did compile in current TS version?

noxzym commented 3 years ago

Ok, last thing, is this tested and did compile in current TS version?

works fine on me with the latest typescript version and not get any error from package shoukaku without using skipLibCheck.