fix(Connector#ready): node options are being merged with Shoukaku defaults - Githubissues

shipgirlproject / Shoukaku

A stable, powerful and updated wrapper around Lavalink

https://guide.shoukaku.shipgirl.moe/

MIT License

287 stars 86 forks source link

fix(Connector#ready): node options are being merged with Shoukaku defaults #94

Closed Allvaa closed 2 years ago

Allvaa commented 2 years ago

fix(Connector): node options are being merged with Shoukaku defaults
feat(Util): improve mergeDefault typings and function
- replace any to generic type in parameters type and return type
- add check if the default value is an empty string https://github.com/Deivu/Shoukaku/blob/8fa683c992746c3fe6f795bf8f11b2b56c76a386/src/Utils.ts#L16
- and i suppose this should read the given keys instead of default keys to remove unnecessary fields or no? https://github.com/Deivu/Shoukaku/blob/afb4ed48e47404997f96b2283baf1efb38482b36/src/Utils.ts#L17

Deivu commented 2 years ago

Thanks for the pr, looks good