search

shipharbor / merry

:ocean::ocean::sailboat::ocean::ocean: - cute streaming API framework
MIT License
312 stars 21 forks source link

question: log process error events #61

Closed nichoth closed 7 years ago

nichoth commented 7 years ago

I see this https://github.com/yoshuawuyts/merry/blob/master/index.js#L134 , but it doesn't look like it is called anywhere?

yoshuawuyts commented 7 years ago

oh yeah lol oops... ✨regression timeeee✨ - I'm currently working on other stuff so this is not a priority for me; PR very welcome so this is booted by default on start, has an option to disable and possiblyyyy a unit test so we never ever forget about this again. But only if you have time and feel like it, no pressure whatsoever. Thanks! :D

On Tue, Jan 31, 2017 at 7:48 PM nichoth notifications@github.com wrote:

I see this https://github.com/yoshuawuyts/merry/blob/master/index.js#L134 , but it doesn't look like it is called anywhere?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/merry/issues/61, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlejkgJdo8gJApl6aniGgc2tdAxOXPks5rYACQgaJpZM4LzdoZ .

yoshuawuyts commented 7 years ago

Doneeeee