search

shipharbor / merry

:ocean::ocean::sailboat::ocean::ocean: - cute streaming API framework
MIT License
312 stars 21 forks source link

rmrf notFound method #80

Closed lrlna closed 7 years ago

lrlna commented 7 years ago

We should let users handle not found on their end.

This is a breaking change, so we should wait to merge until we hook up nanostack ✨

codecov-io commented 7 years ago

Codecov Report

Merging #80 into master will decrease coverage by -0.37%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   81.42%   81.06%   -0.37%     
==========================================
  Files           5        5              
  Lines         210      206       -4     
==========================================
- Hits          171      167       -4     
  Misses         39       39
Impacted Files Coverage Δ
index.js 69.74% <ø> (-0.99%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b628b06...47cf836. Read the comment docs.

lrlna commented 7 years ago

don't have a notFound method anymore