search

shipharbor / merry

:ocean::ocean::sailboat::ocean::ocean: - cute streaming API framework
MIT License
312 stars 21 forks source link

let's remove json schema out of merry #84

Closed lrlna closed 7 years ago

lrlna commented 7 years ago

This moves it out of merry's core + mentions a reference to the newly created json-schema-middleware package. This also a breaking change.

a solution to close #82

lrlna commented 7 years ago

hmmmm didn't think gateway was using schema stuff too; i'll look into fixing that tom morn o.O

(that's the reason travis is failin)

yoshuawuyts commented 7 years ago

amaze! :D

On Mon, Mar 6, 2017 at 12:28 AM Irina Shestak notifications@github.com wrote:

hmmmm didn't think gateway was using schema stuff too; i'll look into fixing that tom morn o.O

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/shipharbor/merry/pull/84#issuecomment-284272667, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlehulzMCZ4Xj4uj8np9Hi97UCoCL8ks5ri0UxgaJpZM4MTknl .

lrlna commented 7 years ago

woops i forgot on tuesday; but fixed nowwwww :D

codecov-io commented 7 years ago

Codecov Report

Merging #84 into master will decrease coverage by 2.26%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   81.42%   79.16%   -2.27%     
==========================================
  Files           5        5              
  Lines         210      192      -18     
==========================================
- Hits          171      152      -19     
- Misses         39       40       +1
Impacted Files Coverage Δ
middleware.js 100% <ø> (ø) :white_check_mark:
gateway.js 100% <100%> (ø) :white_check_mark:
parse.js 78.94% <0%> (-5.27%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b628b06...f2fc88f. Read the comment docs.

codecov-io commented 7 years ago

Codecov Report

Merging #84 into master will decrease coverage by 2.26%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   81.42%   79.16%   -2.27%     
==========================================
  Files           5        5              
  Lines         210      192      -18     
==========================================
- Hits          171      152      -19     
- Misses         39       40       +1
Impacted Files Coverage Δ
middleware.js 100% <ø> (ø) :white_check_mark:
gateway.js 100% <100%> (ø) :white_check_mark:
parse.js 78.94% <0%> (-5.27%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b628b06...f2fc88f. Read the comment docs.

lrlna commented 7 years ago

no longer a thing, yo