search

shipharbor / merry

:ocean::ocean::sailboat::ocean::ocean: - cute streaming API framework
MIT License
312 stars 21 forks source link

Responding with an object has a content type of `json` instead of `application/json` #99

Closed alexframe closed 7 years ago

alexframe commented 7 years ago

If a response is an object, a Content-Type of json is set.

According to the valid mime types list on MDN, this should be application/json.

It looks like this was changed in 7816e54 - was this intentional?

Should we change this back to conform with MDN?

yoshuawuyts commented 7 years ago

yep, should be application/json - PR welcome!

On Wed, Jun 28, 2017 at 3:32 AM Alex notifications@github.com wrote:

If a response is an object, a Content-Type of json is set.

According to the valid mime types list https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Complete_list_of_MIME_types on MDN, this should be application/json.

It looks like this was changed in 7816e54 https://github.com/shipharbor/merry/commit/7816e547e184e48f46c50919063d96792d5f64c7

  • was this intentional?

Should we change this back to conform with MDN?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/shipharbor/merry/issues/99, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWleqcvxw5OJGuVb6EIgilW5HrtcXiVks5sIa0fgaJpZM4OHYoi .

lrlna commented 7 years ago

yep! totally missed this in the rewrite; got it fixed in #100 tho

lrlna commented 7 years ago

@alexframe lemme know if it's all good ^___^

alexframe commented 7 years ago

Look good @lrlna! Thanks.

I've opened #102 to update the tests to test for this in future too :+1:

Thanks for fixing and releasing so quickly.

lrlna commented 7 years ago

Awesome! I merged those two in as well. Thanks! :) I am gonna add you as a contributor :sparkles: