search

shipperhq / module-address-autocomplete

ShipperHQ Address Autocomplete for Magento 2
Open Software License 3.0
15 stars 20 forks source link

Billing Address Form Support #21

Closed jerrylopez closed 2 years ago

jerrylopez commented 4 years ago

Summary

This PR introduces autocomplete support for the billing address form in checkout.

Testing Instructions

Please keep in mind when testing Magento has two options for display the billing address form: within each payment method and outside the payment method (shared). This configuration can be changed in Stores > Settings > Configuration > Sales > Checkout > Checkout Options > Display Billing Address On

wsadasmit commented 4 years ago

Hi jerrylopez, thanks for the contribution! I've scheduled it to be reviewed.

wsajosh commented 3 years ago

Hi @jerrylopez Apologies for the delay in getting to this. I've just tested this out and unfortunately its not working for me. I'm running 2.4.0. It's working fine in every other spot, but I'm not seeing the dropdown when adding a billing address in guest checkout

jerrylopez commented 3 years ago

@wsajosh This was developed and tested on 2.3.x. I'll need to see what's up with 2.4

bradleybernard commented 3 years ago

@jerrylopez @wsajosh any updates on this one? Would be awesome to have it on billing address as well :)

jerrylopez commented 3 years ago

@bradleybernard no update yet. It'll be about 2 weeks before I can take a look.

wsajosh commented 2 years ago

Unfortunately we're still seeing issues with this PR not working as intended and throwing errors. After some internal discussions, we've decided to reject this PR I'm afraid. We're looking to stay focused within the shipping step of checkout, we're not looking to maintain changes to the billing page at this time.