search

shipperhq / module-address-autocomplete

ShipperHQ Address Autocomplete for Magento 2
Open Software License 3.0
15 stars 20 forks source link

Installed module, but disabled in admin, still loads google API on customer account address entry #30

Closed ProxiBlue closed 2 years ago

ProxiBlue commented 2 years ago

With the module installed via composer, but disabled in admin

image

the google maps API is still loaded on customer new address entry screen (customer account -> add new address) Due to fact CSP whitelists are not setup (ref #26), this causes a console error:

image

and shown with CSP whitelist setup (installed via patch from derived PR : https://github.com/shipperhq/module-address-autocomplete/pull/27

2021-10-27_09-21

warnings are produced:

image

Expected behaviour would be that all address autocomplete functionality stops due to admin disabled setup.

Tested on magento 2.4.3

wsadasmit commented 2 years ago

Thanks for the details, @ProxiBlue , I'll get this scheduled to be reviewed so that any needed changes can be made. Thank you for including in your description that the only impact is these console messages.