search

shipperhq / module-address-autocomplete

ShipperHQ Address Autocomplete for Magento 2
Open Software License 3.0
15 stars 20 forks source link

Refactor customer address entry autocomplete #33

Closed ProxiBlue closed 2 years ago

ProxiBlue commented 2 years ago

I have refactored address entry autocomplete.

The current module code completely replaces the core edit.phtml template, which is not necessary. It causes potential magento upgrade issues (due to replaced address template), and makes the module incompatible with Hyva Theme

This change now also fixes https://github.com/shipperhq/module-address-autocomplete/issues/30 as the autocomplete code is negated/included via xml directive: https://github.com/ProxiBlue/module-address-autocomplete/blob/refactor_customer_address_entry_autocomplete/src/view/frontend/layout/customer_address_form.xml#L15

This change negates the issue https://github.com/shipperhq/module-address-autocomplete/issues/31 as the address entry fields are kept as per the core / theme installed edit,phtml. I suspect the reason the fields are re-ordered in such a way is due to an older magento version edit.phtml being used.

I have tested this in clean 2.4.2 and 2.4.3

wsadasmit commented 2 years ago

Thanks for the updates @ProxiBlue, I'll get this PR added to the previously raised issues you reference.