search

shipperhq / module-shipper

Base ShipperHQ Repo
Open Software License 3.0
21 stars 21 forks source link

StockHandlerFactory check for Inventory module usage fails if module is installed and disabled #122

Closed steven-hoffman-jomashop closed 2 years ago

steven-hoffman-jomashop commented 2 years ago

For https://github.com/shipperhq/module-shipper/blob/20.50.0/src/Model/Carrier/Processor/StockHandlerFactory.php. The isAdobeMSIInstalled and isLegacyStockRegistryInstalled can return incorrect results if the module is installed and disabled.

This can be easily fixed by adding a Magento\Framework\Module\Manager::isEnabled check on the relevant modules. (Magento_InventoryCatalog & Magento_CatalogInventory)

shqsupport commented 2 years ago

Hi Steven,

Thank you for contacting us regarding this issue. We see that you are correct, this can return a positive result for a disabled module. We have passed this to our development team for impact assessment.

wsajosh commented 2 years ago

@steven-hoffman-jomashop Thanks for raising this. We've released version 20.50.1 which addresses this. Please update and re-test